On Mon Jun 5 19:51:14 2023 +0000, Esme Povirk wrote:
Why is the change to EXTRADEFS needed here?
It is needed because otherwise we'd get errors like this:
``` ../dlls/windowscodecs/libjpeg.c: In function ‘jpeg_decoder_initialize’: ../dlls/windowscodecs/libjpeg.c:170:41: error: ‘JPEG_LIB_VERSION’ undeclared (first use in this function); did you mean ‘ELF_VERSION’? 170 | jpeg_CreateDecompress(&This->cinfo, JPEG_LIB_VERSION, sizeof(struct jpeg_decompress_struct)); ```
I could have added the define at the top of jpeglib.h, however I wanted to keep the modifications to the original source files to a minimum. Would you like me to move the define from EXTRADEFS to jpeglib.h?