On Fri Feb 7 20:18:51 2025 +0000, Nikolay Sivov wrote:
What this needs first is tests, and then fixes would could normally touch more than just absolute minimum, like having some helpers etc. But only renaming local variables is not something we normally do.
Yes, three tests are fixed if you review.
absolute minimum
That is why commits have been split up to make things trivially clear.
But only renaming local variables is not something we normally do.
Except it isn't just renaming variables if you actually looked it over.
No offense but this attitude to new contributions explains a lot about why this code is so horrifically inconsistent and in disrepair. There are multiple buffer overflows and deref of invalid ptr's, both of which controllable by the user and other subtle bugs. A few have been addressed here.