Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/texture.c:
hr = IDirect3DCubeTexture9_GetLevelDesc(texture, m, &desc);
ok(hr == D3D_OK, "Unexpected hr %#x.\n", hr);
size = desc.Width;
for (f = 0; f < 6; f++) {
hr = IDirect3DCubeTexture9_LockRect(tex, f, 0, &lock_rect, NULL, D3DLOCK_READONLY);
texelsize.x = (f == 0) || (f == 1) ? 0.0f : 2.0f / size;
texelsize.y = (f == 2) || (f == 3) ? 0.0f : 2.0f / size;
texelsize.z = (f == 4) || (f == 5) ? 0.0f : 2.0f / size;
hr = IDirect3DCubeTexture9_LockRect(texture, f, m, &lock_rect, NULL, D3DLOCK_READONLY); ok(hr == D3D_OK, "Couldn't lock the texture, error %#x\n", hr); if (SUCCEEDED(hr)) {
We should just get rid of the if, here or in a separate (preceding) patch.