Re: [PATCH 0/3] MR7577: d3dx9: Implement D3DXSaveVolumeToFile{A,W,InMemory}().

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/volume.c:
> }
>
> +static void set_vec3(D3DXVECTOR3 *v, float x, float y, float z)
> +{
> - v->x = x;
> - v->y = y;
> - v->z = z;
>
> +}
> -
>
> +static const D3DXVECTOR4 quadrant_color[] = {
> - { 1.0f, 0.0f, 0.0f, 1.0f }, { 0.0f, 1.0f, 0.0f, 1.0f }, { 0.0f, 0.0f, 1.0f, 1.0f }, { 1.0f, 1.0f, 1.0f, 1.0f },
> - { 1.0f, 1.0f, 1.0f, 1.0f }, { 0.0f, 0.0f, 1.0f, 1.0f }, { 1.0f, 0.0f, 0.0f, 1.0f }, { 0.0f, 1.0f, 0.0f, 1.0f },
>
> +};
> -
>
> +static void WINAPI fill_func_volume(D3DXVECTOR4 *value, const D3DXVECTOR3 *texcoord,
> -
>                               const D3DXVECTOR3 *texelsize, void *data)

Indent the continuation by 8 spaces, like you did for the next function. Both `texcoord` and `texelsize` could use a name more in the current style (up to you, maybe just add underscores to separate words, or simplify the names like `coord` or `c` for the former and `size` for the latter)