Re: [PATCH 0/1] MR2609: shlwapi: Implement StrFormatByteSizeEx

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/shlwapi/tests/string.c:
> -
> - hr = pStrFormatByteSizeEx(0xdeadbeef, 2, szBuff, 0);
> - ok(hr == E_INVALIDARG, "Error code : %#lx expected : %#lx\n", hr, E_INVALIDARG);
> -
> - hr = pStrFormatByteSizeEx(0xdeadbeef, 10, szBuff, 256);
> - ok(hr == E_INVALIDARG, "Error code : %#lx , expected : %#lx\n", hr, E_INVALIDARG);
> -
> - hr = pStrFormatByteSizeEx(2147483647, 1, szBuff, 256);
> - ok(hr == S_OK, "Invalid arguments \n");
> - ok(!wcscmp(szBuff, L"2.00 GB"), "Formatted %s wrong: got %ls, expected 2.00 GB\n",
> -
> wine_dbgstr_longlong(test_value), szBuff);
> -
> - hr = pStrFormatByteSizeEx(2147483647, 2, szBuff, 256);
> - ok(hr == S_OK, "Invalid arguments \n");
> - ok(!wcscmp(szBuff, L"1.99 GB"), "Formatted %s wrong: got %ls, expected 1.99 GB\n",
> -
> wine_dbgstr_longlong(test_value), szBuff);

Here you might as well use enum member names for flags. For ok() traces, imho simply calling it "Unexpected" and printing actual value is enough.