Re: [PATCH 0/5] MR665: win32u: Tweak reading / writing of DEVMODEW into the registry.

[Rémi Bernon (＠rbernon)]

On Thu Aug 18 03:55:07 2022 +0000, Zhiyi Zhang wrote:
> Why is ENUM_REGISTRY_SETTINGS getting special treatment? The display
> mode written into the registry should be a full display mode. Or, are
> you doing a check for the required flags? If that's case, I don't think
> it's the responsibility of the macro. What I had in mind for the macro
> is something like the following and it should be enough.
> `
> if (mode->dmFields & flag)
>    if (!(ret = set_reg_value( hkey, (name), REG_DWORD, &mode->field,
> sizeof(mode->field) )))
>        goto done;
> `

I was seeing some failures with missing DM_BITSPERPEL field, I'll have a better look.