Re: [PATCH v2 0/4] MR44: vkd3d-shader/dxil: Read and validate DXIL bitcode blocks.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/dxil.c:
> - if (!(count = abbrev->count))
> -
>    return true;
> - if (count == 1 && abbrev->is_array)
> -
>    return false;
> -
> - /* First operand is the record code. The array is included in the count, but will be done separately. */
> - count -= abbrev->is_array + 1;
> - if (!(record = vkd3d_malloc(sizeof(*record) + count * sizeof(record->operands[0]))))
> - {
> -
>    ERR("Failed to allocate record with %u operands.\n", count);
> -
>    return false;
> - }
> -
> - if (!abbrev->operands[0].read_operand(parser, abbrev->operands[0].context, &code))
> -
>    return false;
> - if (code > ~0u)

Not a strong opinion, but I would find it more idiomatic to use `UINT_MAX` instead of `~0u`.