Re: [PATCH 0/3] MR382: vkd3d-shader/tpf: Replace sm4 register structs with vkd3d-shader register structs, part 4.

[Henri Verbeet (＠hverbeet)]

> +        default:
> +            FIXME("Unhandled register modifier %#x.\n", src->modifiers);
> +            mod_token = VKD3D_SM4_REGISTER_MODIFIER_NONE;
> +            break;

That should cause compilation to fail, right? (And probably with something like an internal compiler error, because this is something vkd3d-shader itself would trigger.)
> -static uint32_t sm4_src_register_order(const struct sm4_src_register *src)
> +static uint32_t vkd3d_shader_src_param_order(const struct vkd3d_shader_src_param *src)

The naming here seems a bit unfortunate. As far as I can tell, this function determines the TPF source token count, which isn't a property of the vsir source parameter as such. I.e., I'd expect this to be called something along the lines of "sm4_token_count_from_src_register()", although you could possibly make a case for something like "vsir_src_register_get_tpf_token_count()". (vkd3d_shader_dst_param_order() has that issue as well.)