On Fri Sep 8 08:09:11 2023 +0000, Ziqing Hui wrote:
What I mean is: if we hold a pointer in `struct wg_container_format`, we'll need to convert the 32-bit `struct wg_container_format` to 64-bit in wow64 thunk. So I finnally decide to hold a char[8] in it instread of a char pointer, it's just like the codec data in `struct wg_format`.
I don't understand how the enum is useful for anything, it requires additional changes to convert it to GStreamer caps, and that's true for every new format we could add.
Having a `char *` provided by the client, you could simply call `gst_caps_from_string` on it from the unix side and it will let us support any format without having to add it to the conversion function.
Yes, you need to convert that pointer in the wow64 thunk, but you do that already for the format pointer, so it's not worse (and in any case I don't think it's a big deal).