On Tue Sep 19 18:15:53 2023 +0000, Aidan Khoury wrote:
changed this line in [version 9 of the diff](/wine/wine/-/merge_requests/3870/diffs?diff_id=70283&start_sha=69533132d16cf72bde70431c4fa6e24b20bdc10b#acda5f5d040f90ecb29756b0c057cc22a0c00c32_753_752)
Relocations are not guaranteed to be aligned. The other PE image structures require unalignment as well for the case that mspatcha compiled as a 64-bit PE image (8-byte alignment default) will be manipulating 32-bit PE image buffers which defaults to 4-byte alignment.
I may be wrong about all of this in wine's case, forgive me as I am also not super familiar with GCC's default type alignment. I noticed in dlls/msvcrt/string.c uses unaligned typedefs, so I would have assumed that types are aligned to their own size boundary.
Let me know what you think of 6088f31e