Zebediah Figura (@zfigura) commented about dlls/ir50_32/ir50.c:
- TRACE("in->bpp = %d\n", in->bmiHeader.biBitCount);
- TRACE("in->height = %d\n", in->bmiHeader.biHeight);
- TRACE("in->width = %d\n", in->bmiHeader.biWidth);
- TRACE("in->compr = %#x\n", in->bmiHeader.biCompression);
- if ( in->bmiHeader.biCompression != IV50_MAGIC )
- {
TRACE("can't do %#x compression\n", in->bmiHeader.biCompression);
return ICERR_BADFORMAT;
- }
- if ( in->bmiHeader.biBitCount != 24 )
- {
TRACE("can't do %d bpp\n", in->bmiHeader.biBitCount);
return ICERR_BADFORMAT;
- }
Is the compressed bit depth meaningful for IV50? (Same for the patch implementing decompression later). Or if we need to care about validating this anyway, it'd be nice to at least have a test for that in the tree.