Rémi Bernon (@rbernon) commented about dlls/mf/tests/transform.c:
- ok(ret == 0, "Release returned %lu\n", ret);
- ok(i == 1, "got %lu output samples\n", i);
- ret = check_mf_sample_collection(output_samples, &output_sample_desc_rgb, L"rgb32frame-vp.bmp");
- ok(ret == 0, "got %lu%% diff\n", ret);
- IMFCollection_Release(output_samples);
- winetest_pop_context();
- winetest_push_context("WMV1 -> RGB (positive stride)");
- check_mft_set_input_type_required(transform, input_type_desc);
- check_mft_set_input_type(transform, input_type_desc);
- check_mft_get_input_current_type_(transform, expect_input_type_desc, FALSE, TRUE);
- check_mft_set_output_type_required(transform, output_type_desc_rgb_positive_stride);
- check_mft_set_output_type(transform, output_type_desc_rgb_positive_stride, S_OK);
- check_mft_get_output_current_type_(transform, expect_output_type_desc_rgb_positive_stride, FALSE, TRUE);
Same here as for YUV, I don't think there's much point having two different `expect_output_type_desc_rgb` and `expect_output_type_desc_rgb_positive_stride`, as they are the same type. And then checking the output also feels redundant.