Re: [PATCH v14 0/4] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.

[Elizabeth Figura (＠zfigura)]

Elizabeth Figura (@zfigura) commented about dlls/sechost/service.c:
> - if (details->devicetype != data->devicetype) return FALSE;
> - if (filter->dbch_devicetype == DBT_DEVTYP_DEVICEINTERFACE)
> - if (details->devicetype == DBT_DEVTYP_DEVICEINTERFACE)
> {
> -
>    DEV_BROADCAST_DEVICEINTERFACE_W *filter_iface = (DEV_BROADCAST_DEVICEINTERFACE_W *)filter;
> -
>    DEV_BROADCAST_DEVICEINTERFACE_W *event_iface = (DEV_BROADCAST_DEVICEINTERFACE_W *)event;
> -
>    if (filter_iface->dbcc_size == offsetof(DEV_BROADCAST_DEVICEINTERFACE_W, dbcc_classguid)) return TRUE;
> -
>    return IsEqualGUID( &filter_iface->dbcc_classguid, &event_iface->dbcc_classguid );
> -
>    if (details->filter.deviceinterface.all_classes) return TRUE;
> -
>    return IsEqualGUID( &details->filter.deviceinterface.class, &data->event.device_interface.class_guid );
> }
> - FIXME( "Filter dbch_devicetype %lu not implemented\n", filter->dbch_devicetype );
> - return TRUE;
> - return !lstrcmpiW( details->filter.device.name_info->Name.Buffer, data->event.handle.handle_file_path );

Shouldn't we be explicitly checking for DBT_DEVTYP_* here?

Also, I'd prefer the wcs* family to the nonstandard lstr* family in new code.