Elizabeth Figura (@zfigura) commented about dlls/d3d9/tests/device.c:
- hr = IDirect3DDevice9_QueryInterface(device, &IID_IDirect3DDevice9On12, (void **)&d3d9on12);
- ok(hr == S_OK, "Got hr %#lx.\n", hr);
- ref = IDirect3DDevice9On12_Release(d3d9on12);
- todo_wine
- ok(ref == 0, "Got refcount %lu.\n", ref);
- ref = IDirect3DDevice9_Release(device);
- ok(ref == 0, "Got refcount %lu.\n", ref);
- IDirect3D9_Release(d3d9);
- hr = pCreateDXGIFactory2(0, &IID_IDXGIFactory4, (void **)&factory);
- ok(hr == S_OK, "Got hr %#lx.\n", hr);
- hr = IDXGIFactory4_EnumAdapters(factory, 0, &adapter);
- ok(hr == S_OK, "Got hr %#lx.\n", hr);
- IDXGIFactory4_Release(factory);
- hr = pD3D12CreateDevice((IUnknown *)adapter, D3D_FEATURE_LEVEL_11_0, &IID_ID3D12Device, (void **)&d3d12device);
This is missing an ok(). We also never release this device.