On Wed Sep 18 03:03:16 2024 +0000, Elizabeth Figura wrote:
I was going to suggest anyway that using codec_format instead of
preferred_format for uncompressed video would make sense;
Do you mean that, in wg_parser_stream_get_codec_format(), for
uncompressed situation, we should also return codec_format instead of returning preferred_format? Yes, if the codec format is uncompressed, we should return it first, since that's what applications expect.
But even if we return codec_format in wg_parser_stream_get_codec_format() for uncompressed, this is still not what the application expect.
The application expect the result of wm_reader:stream_props_GetMediaType() to be the actual output format, so that it can create d3d texture later based on it.
However, our codec_format is the output format of the first decodebin (see: wg_parser.c:pad_added_cb()), it is the format before handled by videoconverter. Application expect it to be the final output format.