26 Sep
2023
26 Sep
'23
3:11 p.m.
On Tue Sep 26 15:11:44 2023 +0000, Henri Verbeet wrote:
The thread group size is still not read.
Right, but if the affected shaders are already going to fail due to e.g. unimplemented instructions, that's somewhat moot. The practical thing to do in that case would be to implemented reading the thread group size before implementing the required instructions for those shaders, although perhaps ideally not reading a thread group size for shaders that require one would cause compilation to fail on its own.
Yeah, failing on emit_unhandled() and/or not compiling binaries from failed dxcompiler compilations has eliminated the crashes I saw before.