Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl_codegen.c:
hlsl_fixme(ctx, &ctx->location, "Writing fx_2_0 binaries is not implemented.");
return VKD3D_ERROR_NOT_IMPLEMENTED;
- }
- else if (ctx->profile->major_version == 4)
- {
return hlsl_fx_4_write(ctx, out);
- }
- else if (ctx->profile->major_version == 5)
- {
hlsl_fixme(ctx, &ctx->location, "Writing fx_5_0 binaries is not implemented.");
return VKD3D_ERROR_NOT_IMPLEMENTED;
- }
- else
- {
vkd3d_unreachable();
return VKD3D_ERROR_INVALID_ARGUMENT;
There is no point in putting any code after `vkd3d_unreachable()`, the compiler is expected to discard it anyway.