Re: [PATCH 0/1] MR9209: vccorlib140: Add stubs + tests for exceptions-related functions.

[Piotr Caban (＠piotr)]

Piotr Caban (@piotr) commented about dlls/vccorlib140/tests/vccorlib.c:
> +} cxx_type_info;
> +typedef struct
> +{
> - UINT count;
> - unsigned int info[1];
>
> +} cxx_type_info_table;
> +typedef struct
> +{
> - UINT flags;
> - unsigned int destructor;
> - unsigned int custom_handler;
> - unsigned int type_info_table;
>
> +} cxx_exception_type;
> -
>
> +#ifdef USE_COMPILER_EXCEPTIONS
> +static CALLBACK LONG cxx_exception_filter(EXCEPTION_POINTERS *ptrs)

This code depends on a lot of exception handling related details. Because of that it will not work in i386 case (in theory one can compile i386 tests with MSVC, it will also need to be updated when i386 Clang compiler exception support is enabled). It also leaks exception objects. I think it would be best to avoid most of these tests.

If it's really needed to test that I would suggest to limit it to only getting the exception object and doing some tests on it.