Jacek Caban (@jacek) commented about server/console.c:
};
static struct list screen_buffer_list = LIST_INIT(screen_buffer_list); +static struct list console_input_list = LIST_INIT(console_input_list);
I think it would be cleaner to store the list inside the console struct instead. On a related note, the same likely applies to the screen buffer list, its global scope is probably a leftover from the old console architecture.