Re: [PATCH v5 0/6] MR1628: ntdll: Implement Low Fragmentation Heap.

[Jinoh Kang (＠iamahuman)]

Jinoh Kang (@iamahuman) commented about dlls/ntdll/heap.c:
> +/* lookup a free block using the group free_bits, the current thread must own the group */
> +static inline LONG group_find_free_block( struct group *group, SIZE_T block_size, struct block **block )
> +{
> +#if defined(__GNUC__) && ((__GNUC__ > 3) || ((__GNUC__ == 3) && (__GNUC_MINOR__ >= 3)))
> - int i = __builtin_ffs( group->free_bits ) - 1;
>
> +#else
> - int i = sizeof(group->free_bits) * 8;
> - while (i--) if (group->free_bits & (1 << i)) break;
>
> +#endif
> - /* we remove the group from the free list once all its blocks are used, i will never be -1 */
> - *block = group_get_block( group, block_size, i );
> - return InterlockedAnd( &group->free_bits, ~(1 << i) ) & ~(1 << i);
>
> +}
> -
>
> +/* allocate a new group block using non-LFH allocation, returns a group owned by current thread */
> +static struct group *group_allocate( struct heap *heap, ULONG flags, SIZE_T block_size, struct category *category )

The `category` parameter is unused.