Re: [PATCH 0/4] MR2928: xmllite/writer: Implement more APIs

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/xmllite/writer.c:
> -
>    return WC_E_NAMECHARACTER;
> -
> - p = pwszName;
> - while (*p)
> - {
> -
>    if (*p == ':')
> -
>    {
> -
>        p++;
> -
>        continue;
> -
>    }
> -
> -
>    if (!is_ncnamechar(*p))
> -
>        return WC_E_NAMECHARACTER;
> -
> -
>    p++;
> - }

This could use the same sequence to validate NCName that the reader is using. My understanding is that WriteName() does not accept qualified names, but you don't have such tests.