Re: [PATCH 0/1] MR3132: vbscript: Coerce to VT_BOOL when evaluating jump conditions.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/vbscript/interp.c:
> - default:
> -
>    FIXME("unsupported for %s\n", debugstr_variant(val.v));
> -
>    release_val(&val);
> -
>    return E_NOTIMPL;
> }
> - return S_OK;
> - else
> - {
> -
>    V_VT(&v) = VT_EMPTY;
> -
>    hres = VariantChangeType(&v, val.v, VARIANT_LOCALBOOL, VT_BOOL);
> - }
> -
> - release_val(&val);
> -
> - if (SUCCEEDED(hres))
> -
>    *b = V_BOOL(&v) == VARIANT_TRUE;

Please avoid comparison to `VARIANT_TRUE`, that makes values like `TRUE` behave like `VARIANT_FALSE`. Comparing to `VARIANT_FALSE` would be better, or perhaps something `!!V_BOOL(&v)`.