On Tue Jun 6 11:54:07 2023 +0000, **** wrote:
Marvin replied on the mailing list:
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=133474 Your paranoid android. === debian11 (32 bit report) === user32: msg.c:6897: Test failed: SetFocus(hwnd) on a button: 4: the msg 0x0007 was expected, but got msg 0x0005 instead msg.c:6897: Test failed: SetFocus(hwnd) on a button: 5: the msg 0x0138 was expected, but got msg 0x030f instead msg.c:6897: Test failed: SetFocus(hwnd) on a button: 6: the msg 0x0111 was expected, but got msg 0x001c instead msg.c:6897: Test failed: SetFocus(hwnd) on a button: 8: the msg 0x8000 was expected, but got msg 0x0086 instead msg.c:6897: Test failed: SetFocus(hwnd) on a button: 9: the msg sequence is not complete: expected 0000 - actual 0006
This one at least doesn't seem obviously related, as it's been seen a couple of time in the past, as in:
* https://test.winehq.org/data/f266dc094a9b4fbe95792ed706891609901834e3/linux_... * https://test.winehq.org/data/0336d66ea1926f62dd303e266683fef7de6e9a87/linux_... * https://test.winehq.org/data/38b0a4005a1b0fafba74f1d33cbdefd6c1bec5c2/linux_... * https://test.winehq.org/data/345ca7e061061e5511af85a45931350acb3764d7/linux_...
Re-running the test independently also doesn't always cause the failure:
* https://testbot.winehq.org/JobDetails.pl?Key=133477 * https://testbot.winehq.org/JobDetails.pl?Key=133478 * https://testbot.winehq.org/JobDetails.pl?Key=133479
I'm going to blame fvwm for that, as it's known to suffer from a race condition which steals focus out of our windows (see https://github.com/fvwmorg/fvwm/pull/101).
Fwiw according to https://test.winehq.org/data/patterns.html#user32:msg, I think openbox is more reliable from this point of view. It has a couple of different failures but in general it looks like it is even more stable than fvwm.