Re: [PATCH v4 0/5] MR2103: Add support for WinRT app dark mode

[Mohamad Al-Jaf (＠maljaf)]

On Tue Feb  7 10:40:45 2023 +0000, Rémi Bernon wrote:
> > Not sure if it's fine to add IUISettings3 by itself without
>
> IUISettings first. IUISettings3 doesn't seem to be inherited.
> Yes, WinRT doesn't use inheritance. So I think it's fine to skip some
> interfaces unless some app queries them.
> Haven't looked at the registry problems, though ofc they need to be
> addressed if there's any.

It looks like Chromium queries IUISettings and IUISettings2. But it's not relevant to this MR so no reason to add them.

I think the registry issue should be fixed after creating the key AppsUseLightTheme. Though, it's still unclear why RegSetValueExW creates the key locally but not in the testbot.