Re: [PATCH 0/5] MR3975: Improve module's debug information.

[Alexandre Julliard (＠julliard)]

Alexandre Julliard (@julliard) commented about include/dbghelp.h:
> - {
> -
>    FORMAT_DWARF2 = 0x00000001,
> -
>    FORMAT_DWARF3 = 0x00000002,
> -
>    FORMAT_DWARF4 = 0x00000004,
> -
>    FORMAT_DWARF5 = 0x00000008,
> -
>    FORMAT_DWARF  = 0x0000000F,
> -
>    FORMAT_STABS  = 0x00010000,
> - }                           DebugFormatMask;
> - enum wine_sysmodule
> - {
> -
>    WINE_SYSMODULE_NONE,
> -
>    WINE_SYSMODULE_ELF,
> -
>    WINE_SYSMODULE_MACHO,
> - }                           SystemModule;
>
> +} WINE_IMAGEHLP_MODULEW64;
> +#define WINE_IMAGEHLP_MODULE_MAGIC 0xB0507E17

That's not very nice. Do we really need to export that info in the first place? And if so, do we really need to abuse an existing API structure?