Re: [PATCH 0/2] MR2560: dinput: Add test and fix EnumObjects callback return value handling.

[Florian Will (＠w-flo)]

On Mon Apr  3 06:49:14 2023 +0000, **** wrote:
> Marvin replied on the mailing list:
> Hi,
> It looks like your patch introduced the new failures shown below.
> Please investigate and fix them before resubmitting your patch.
> If they are not new, fixing them anyway would help a lot. Otherwise
> please ask for the known failures list to be updated.
> The tests also ran into some preexisting test failures. If you know how
> to fix them that would be helpful. See the TestBot job for the details:
> The full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=131412
> Your paranoid android.
> === w7u_adm (32 bit report) ===
> dinput:
> device8: Timeout

I'm not sure if my patch to the test could have possibly introduced this new failure? I mean, sure, the behavior when returning -1 from the callback instead of DIENUM_CONTINUE / DIENUM_STOP is not specified in the docs. So I guess win7 would be free to do something that would end up e.g. blocking the thread. I suspect that behavior would be pretty unlikely though, and [it didn't reproduce when I manually resubmitted the test](https://testbot.winehq.org/JobDetails.pl?Key=131414).