19 Apr
2023
19 Apr
'23
8:03 p.m.
On Fri Apr 14 07:31:35 2023 +0000, Nikolay Sivov wrote:
It's not obvious, because tests are working for me without the fix somehow - if you add another clr entry, it is found correctly. I don't see why you'd mention wine-staging for this case if the fix is obvious to you, line count is not a metric to use. I'll take a look at additional tests that I suggested.
Please take a look. Testing that offset is within section bounds is enough to show what your fix changes. Note that your test is broken, because you can't have duplicate GUIDs in the same section. I'm not sure if we enforce that yet.
[0001-Some-tests.txt](/uploads/28e25c7e6a1f356cb53046ffaf9092f6/0001-Some-tests.txt)