Re: [PATCH v5 0/3] MR1046: MfMediaEngine invalid format handling.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/mfmediaengine/tests/mfmediaengine.c:
> -
> -
>    if (!(notify.media_engine = media_engine))
> -
>        goto skip_iter;
> -
> -
>    hr = IMFMediaEngineEx_SetSourceFromByteStream(media_engine, stream, url);
> -
>    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
> -
> -
>    res = WaitForSingleObject(notify.ready_event, 5000);
> -
>    ok(!res, "Unexpected res %#lx.\n", res);
> -
> -
>    if (FAILED(notify.error))
> -
>    {
> -
>        todo_wine_if(tested_formats[i].engine_todo)
> -
>        ok((notify.error == MF_E_INVALIDMEDIATYPE || broken(notify.error == E_INVALIDARG || notify.error == E_UNEXPECTED))
> -
>            && (tested_formats[i].bad_fmt || broken(!tested_formats[i].bad_fmt)), /* Broken: Some formats aren't working on VMs. */
> -
>                "Media engine reported unexpected error %#lx on %s format.\n", notify.error, tested_formats[i].bad_fmt ? "bad" : "good");

It's a bit hard to parse the condition, maybe a `if (tested_formats[i].bad_fmt)` with the corresponding expectations?