On Mon Aug 7 17:49:57 2023 +0000, Esme Povirk wrote:
If all you get is a dumped message sequence, you have to manually compare everything (at least starting from the first expected message that failed, and often starting with the optional messages before that). This includes looking up different types of message constants for every message. And, not being a computer, it's easy to make mistakes or lose your place. Maybe for some reason I don't understand, it's easier for you, but *for me* this makes understanding what happened much easier. Assuming it doesn't actively make things more difficult for you (and I don't see why it would - it's not mutually exclusive with the other changes you want), or significantly increase the code complexity (again, I don't think it does), isn't that enough for it to be worth having?
Here's another alternative I'd be OK with: If any mismatch is found, calculate the common prefix and common suffix. Dump the lengths of those, along with the actual messages in between, and don't try to compare anything in the middle. For only the common messages (prefix/suffix or just the full thing), do a more detailed comparison. This would be a step towards LCS, but it wouldn't have nearly the complexity.