On 13-10-22 18:51, Zebediah Figura wrote:
On 10/13/22 11:40, Francisco Casas wrote:
From: Francisco Casas fcasas@codeweavers.com
Makefile.am | 1 + tests/cast-componentwise-equal.shader_test | 181 +++++++++++++++++++++ 2 files changed, 182 insertions(+) create mode 100644 tests/cast-componentwise-equal.shader_test
So this is great on its own, but naturally it makes me wonder about even more tests :-)
Currently we're testing vector -> struct (illegal), struct -> vector (illegal), array -> struct (legal iff the types match), and struct -> struct (legal [iff the types match?]). We don't test struct -> array, though, and we also don't test struct -> struct with mismatched types.
Similarly with the explicit cast tests, I think there's no tests there for vector -> struct or struct -> vector casts.
That all might not make a difference to the patches you have queued (I think the concern at this point is just about objects?), but I'd be remiss if I didn't at least write down every interesting test that occured to me ;-)
Ok, I am adding these tests in v2.
It made a small difference: it seems that explicit casts are allowed between vectors and structs/arrays with less components.