11 Sep
2023
11 Sep
'23
12:40 p.m.
On Sun Sep 10 08:12:33 2023 +0000, Francisco Casas wrote:
It calls my attention the replacement from shader_instruction_init() to vkd3d_shader_instruction_make_nop(), since the latter doesn't initialize all the instruction fields to zero. Can this change the behavior?
I wish the documentation for VSIR was clearer on this (i.e., it existed, at least; which is part of why I began my effort to write the validator), but my understanding is that once the handler is NOP, no other field of the VSIR instruction should even be read. But the disassembler might be an exception and, even more in view of the validator, it's better to be precise. I'll change so that the whole instruction is reset to zero, except for the location.