Re: [PATCH v2 0/5] MR304: vkd3d-shader: Extend vkd3d_shader_scan_descriptor_info, part 2/2.

[Henri Verbeet (＠hverbeet)]

> @@ -777,11 +777,10 @@ static bool vkd3d_shader_scan_add_descriptor(struct vkd3d_shader_scan_context *c
>      d->register_index = range->first;
>      d->resource_type = resource_type;
>      d->resource_data_type = resource_data_type;
> -    d->flags = flags;
>      d->count = (range->last == ~0u) ? ~0u : range->last - range->first + 1;
>      ++info->descriptor_count;
>
> -    return true;
> +    return d;
>  }
>
>  static void vkd3d_shader_scan_constant_buffer_declaration(struct vkd3d_shader_scan_context *context,

You can't quite do that like this though. As it is, this leaves d->flags uninitialised. We either need to initialise it in vkd3d_shader_scan_add_descriptor(), or in each of the callers. That's an issue in the later patches in this MR as well, and for me at least the tests catch it.