Re: [PATCH v8 0/4] MR8478: cfgmgr32: Device query API part 2: Implement object properties and initial device enumeration in DevCreateObjectQuery

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/cfgmgr32/tests/cfgmgr32.c:
> -
>    ok( !!objects, "got objects %p\n", objects );
> -
>    for (i = 0; i < len; i++)
> -
>    {
> -
>        const DEV_OBJECT *obj = &objects[i];
> -
> -
>        winetest_push_context( "objects[%lu]", i );
> -
>        todo_wine ok( obj->cPropertyCount == 1, "got cPropertyCount %lu != 1\n", obj->cPropertyCount );
> -
>        todo_wine ok( !!obj->pProperties, "got pProperties %p\n", obj->pProperties );
> -
>        if (obj->pProperties)
> -
>            ok( IsEqualDevPropKey( obj->pProperties[0].CompKey.Key, prop_key.Key ),
> -
>                "got property {%s, %#lx} != {%s, %#lx}\n", debugstr_guid( &obj->pProperties[0].CompKey.Key.fmtid ),
> -
>                obj->pProperties[0].CompKey.Key.pid, debugstr_guid( &prop_key.Key.fmtid ), prop_key.Key.pid );
>        winetest_pop_context();
> -
>    }
>    DevFreeObjects( len, objects );
> -
>    winetest_pop_context();

This doesn't look right, `i` is reused here in the inner loop. Do you need to really need to run this test for every `test_cases`?