Re: [PATCH v2 0/3] MR267: vkd3d: Implement GetResourceTiling().

[Henri Verbeet (＠hverbeet)]

>  static bool d3d12_resource_init_tiles(struct d3d12_resource *resource, struct d3d12_device *device)
>  {
> +    unsigned int i, start_idx, subresource_count, tile_count, miplevel_idx;
> +    const struct vkd3d_vk_device_procs *vk_procs = &device->vk_procs;
> +    VkSparseImageMemoryRequirements sparse_requirements_buf[3];

Where did "3" come from?
> +        requirement_count = ARRAY_SIZE(sparse_requirements_buf);
> +        VK_CALL(vkGetImageSparseMemoryRequirements(device->vk_device, resource->u.vk_image,
> +                &requirement_count, sparse_requirements_buf));
> +        for (i = 0; i < requirement_count; ++i)
> +        {
> +            if (!(sparse_requirements_buf[i].formatProperties.aspectMask & VK_IMAGE_ASPECT_METADATA_BIT))
> +            {
> +                sparse_requirements = sparse_requirements_buf[i];
> +                break;
> +            }
> +        }
> +
> +        resource->tiles.tile_extent = sparse_requirements.formatProperties.imageGranularity;
> +        resource->tiles.subresource_count = subresource_count;
> +        resource->tiles.standard_mip_count = sparse_requirements.imageMipTailSize
> +                ? sparse_requirements.imageMipTailFirstLod : resource->desc.MipLevels;
> +        resource->tiles.packed_mip_tile_count = (resource->tiles.standard_mip_count < resource->desc.MipLevels)
> +                ? sparse_requirements.imageMipTailSize / requirements.alignment : 0;

This may leave "sparse_requirements" uninitialised, and the compiler warns about that.