On Wed Nov 22 17:14:50 2023 +0000, Alex Henrie wrote:
Your description of those four cases is correct, and Wine handles all four of them correctly with this patch. I'm not understanding what would be different if we had a "decent" tokenizer. Can you give me an example of a statement that would not be evaluated correctly by the code I am proposing, but that would be evaluated correctly by such a tokenizer?
my point is more about the way to implement the fix rather if the propose fix passes the tests
cmd as of today is barely maintanable because of small adjustements here and there, added over the years
your proposal is such a small adjustment by changing behavior of some helper functions, depending on context, whereas IMO the cause of the issue lies elsewhere