On Wed Oct 26 06:37:42 2022 +0000, Konstantin Kharlamov wrote:
Worth noting, with this patch I'm also getting a new message
0074:err:module:load_dll Library L"winemac.drv" not foundBut that's irrelevant problem: indeed, why would WINE try to load `winemac.drv` on Linux. The new message is on point here, so I hope that wouldn't be a blocker to this MR.
On the other hand, I just realized: `load_dll()` implements a WINAPI `LdrLoadDll()`, whose failure to find a dll may not necessarily be a problem *(e.g. if an app simply searches for a loadable addon or some such)*.
So I presume, I need to modify my patch a little, to only print the error when `if (current_modref)` holds *(i.e. to remove the `else` branch)*. The `current_modref` being set implies we're trying to load the lib because it's required by something else.
I'll update the patch on this evening if there's no opposition.