From: R��mi Bernon rbernon@codeweavers.com
Instead of device_count which is the number of registration updates, and execute the request within the rawinput_mutex to ensure atomicity of the update and consistency between the client and the server state.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53468 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53487 --- dlls/win32u/rawinput.c | 32 +++++++++++++++++--------------- 1 file changed, 17 insertions(+), 15 deletions(-)
diff --git a/dlls/win32u/rawinput.c b/dlls/win32u/rawinput.c index ff686d8fd1f..ba35c7efa09 100644 --- a/dlls/win32u/rawinput.c +++ b/dlls/win32u/rawinput.c @@ -866,13 +866,24 @@ BOOL WINAPI NtUserRegisterRawInputDevices( const RAWINPUTDEVICE *devices, UINT d for (i = 0; i < device_count; ++i) register_rawinput_device( devices + i ); }
- server_devices = malloc( registered_device_count * sizeof(*server_devices) ); - if (server_devices) for (i = 0; i < registered_device_count; ++i) + if ((server_devices = malloc( registered_device_count * sizeof(*server_devices) ))) { - server_devices[i].usage_page = registered_devices[i].usUsagePage; - server_devices[i].usage = registered_devices[i].usUsage; - server_devices[i].flags = registered_devices[i].dwFlags; - server_devices[i].target = wine_server_user_handle( registered_devices[i].hwndTarget ); + for (i = 0; i < registered_device_count; ++i) + { + server_devices[i].usage_page = registered_devices[i].usUsagePage; + server_devices[i].usage = registered_devices[i].usUsage; + server_devices[i].flags = registered_devices[i].dwFlags; + server_devices[i].target = wine_server_user_handle( registered_devices[i].hwndTarget ); + } + + SERVER_START_REQ( update_rawinput_devices ) + { + wine_server_add_data( req, server_devices, registered_device_count * sizeof(*server_devices) ); + ret = !wine_server_call_err( req ); + } + SERVER_END_REQ; + + free( server_devices ); }
pthread_mutex_unlock( &rawinput_mutex ); @@ -883,15 +894,6 @@ BOOL WINAPI NtUserRegisterRawInputDevices( const RAWINPUTDEVICE *devices, UINT d return FALSE; }
- SERVER_START_REQ( update_rawinput_devices ) - { - wine_server_add_data( req, server_devices, device_count * sizeof(*server_devices) ); - ret = !wine_server_call_err( req ); - } - SERVER_END_REQ; - - free( server_devices ); - return ret; }