Re: [PATCH v15 0/6] MR6402: bluetoothapis: Implement basic SDP methods.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/bluetoothapis/sdp.c:
> -
>    (v)->HighPart = BTH_READ_UINT64( (s) );                                                    \
> -
>    (v)->LowPart = BTH_READ_UINT64( (s + 8) );                                                 \
> - } while (0)
> -
>
> +#define SDP_SIZEDESC_1_BYTE 0
> +#define SDP_SIZEDESC_2_BYTES 1
> +#define SDP_SIZEDESC_4_BYTES 2
> +#define SDP_SIZEDESC_8_BYTES 3
> +#define SDP_SIZEDESC_16_BYTES 4
> +#define SDP_SIZEDESC_NEXT_UINT8 5
> +#define SDP_SIZEDESC_NEXT_UINT16 6
> +#define SDP_SIZEDESC_NEXT_UINT32 7
> -
>
> +static inline BYTE data_elem_type( BYTE elem ) { return ( elem & 0b11111000 ) >> 3; }
> +static inline BYTE data_elem_size_desc( BYTE elem ) { return elem & 0b00000111; }
> -

Same comment as in the tests wrt 0b prefix. Then, do these need to be marked inline at all?