Re: [PATCH 0/1] MR2498: msado15: Implement _Recordset Find

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/msado15/filter.y:
> -
> char *stripped = malloc(strlen($3) + 1);
> -
> while(*$3 != '\0')
> -
> {
> -
> 	if(*$3 != '*')
> -
> 	{
> -
> 		stripped[i++] = *$3;
> -
> 	}
> -
> 	$3++;
> -
> }
> -
> FIXME("Stripped: %s, %s\n", debugstr_a($3), debugstr_a(stripped));
> -
> filter_add_string_column(yyget_extra(scanner)->recordset, $1, $2, $3);
> -
> free(stripped);
> - }
> -
> - | TOKEN_AND { FIXME(" AND "); }
> - | TOKEN_OR { FIXME(" OR "); }

If you're not handling them I'd advise just to leave these out, especially since I suspect that the rules themselves aren't actually right.