On Thu Nov 9 21:32:40 2023 +0000, Rémi Bernon wrote:
Not asking to do that now, as it's the same for every of the other interfaces, but could we make these interfaces mandatory and get rid of the ifs everywhere? It's quite pointless to start a process without wl_subcompositor or wl_viewporter as they are pretty much required for the code to behave correctly.
I have added a check at driver init for wl_subcompositor. For wl_viewporter, I am somewhat torn because:
1. There is at least one compositor not supporting the extension at the moment. 2. It's a non-core (although stable) extension. 3. The lack of wp_viewporter is not catastrophic at the moment: a. We wouldn't have proper support for scaled monitors, b. the client subsurface (i.e., vulkan rendering) may transiently leak out of the client area extents.
I could imagine scenarios of using Wine that don't require wp_viewporter at all, e.g., a custom, software-rendering only Wayland compositor that runs some non-accelerated win32 app.