On Wed Feb 14 18:11:12 2024 +0000, Gabriel Ivăncescu wrote:
That's true for pipes, but in the case of the linked bug, it happens when it's redirected to actual files. Python expects it to work because it's redirected to files, so it shouldn't be a problem? Maybe it doesn't cover all cases with pipes, but can you give a small (even if contrived) example where my patch actually introduces *wrong* behavior here so I can investigate it more? I mean even if it doesn't fix all cases like this, it's still better than nothing…
As I noted, I don't have reason to think that your patch is useless or introducing wrong behaviour. I am just saying that it doesn't fully solve the issue. And, e. g., in Proton, for the same files for the same python runtime we will still have to keep something like the present workaround (https://github.com/ValveSoftware/wine/commit/e930e5c0b12355948f38b61611c1d70...) because this name retrieval does not work from Steam runtime while Steam passes stderr fd for a file not accessible from runtine's filesystem, while write to the fd work.