Re: [PATCH v3 0/3] MR6680: msvcp140: Use current locale to convert path in _Fiopen.

[Piotr Caban (＠piotr)]

Piotr Caban (@piotr) commented about dlls/msvcp120/tests/msvcp120.c:
> -
>    const char *path;
> - } tests_a[] = {
> -
>    { "German",    1252, "t\xe4\xcf\xf6\xdf.txt" },
> -
>    { "Polish",    1250, "t\xea\x9c\xe6.txt" },
> -
>    { "Turkish",   1254, "t\xd0\xf0\xdd\xde\xfd\xfe.txt" },
> -
>    { "Arabic",    1256, "t\xca\x8c.txt" },
> -
>    { "Japanese",   932, "t\xb8\xd5.txt" },
> -
>    { "Chinese",    936, "t\x81\x40\xfd\x71.txt" },
> - };
> -
> - /* w -> a */
> - for(i=0; i<ARRAY_SIZE(tests); i++) {
> -
>    if(GetACP() != tests[i].cp) {
> -
>        skip("skipping test for %u (current %u)\n", tests[i].cp, GetACP());
> -
>        continue;
> -
>    }

I would prefer to get read of this skip. Please test if the function is behaving correctly no matter what are the user system settings instead.