Re: [PATCH v2 0/2] MR2690: mfreadwrite/tests: Add more tests for MFCreateSinkWriterFromURL.

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/mfreadwrite/tests/mfplat.c:
> -
>    IMFByteStream **stream;
> -
>    IMFAttributes **attr;
> -
>    IMFSinkWriter **writer;
> -
>    HRESULT hr;
> - } create_sink_writer_from_url_tests[] =
> - {
> -
>    {NULL,     NULL,    NULL,  NULL,    E_INVALIDARG},
> -
>    {NULL,     NULL,    NULL,  &writer, E_INVALIDARG},
> -
>    {NULL,     NULL,    &attr, &writer, E_INVALIDARG},
> -
>    {NULL,     &stream, NULL,  &writer, E_INVALIDARG},
> -
>    {NULL,     &stream, &attr, &writer, S_OK},
> -
>    {tmp_file, NULL,    NULL,  &writer, S_OK},
> -
>    {tmp_file, NULL,    &attr, &writer, S_OK},
> -
>    {tmp_file, &stream, NULL,  &writer, S_OK},
> -
>    {tmp_file, &stream, &attr, &writer, S_OK},
> - };

I already mentioned that before. This is not readable, just add a few cases without this loop.