On Tue Apr 23 17:31:36 2024 +0000, Elizabeth Figura wrote:
Seems like the PR is in a left out state, without a clear approval or
disapproval, this is sadly very common.
I think a ACK/NACK system to allow prominent Wine
contributors/developers to triage MR with Labels early would speed up Wine development significantly without changing anything about how MR are merged. _(This idea is at least better than having to ping everyone as the only option to revive an MR)_ I don't think I understand what you mean. How would that improve anything?
Would you be ok letting @zfigura handle this MR and notify you when
this MR is ready, so to save you time and allow you to review the MR only when everything is supposed to be fully ready? As I said in [1], I think that this merge request is in good shape, except for 4/7 which is less related to sockets. I agree that patch is ugly, but on the other hand I don't see a clearly better approach. [1] https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_38573
A system that allow developers to label explicitly in the huge list of MR the one considered ready would be great to save time, this is a ugly patchwork solution to get around only one person merging MR, because the Wine project is so large I don't think anyone can handle it alone anymore.
What I also have been noticing recently is a lot of new developers are submitting patches without knowing how to name commits properly.
For the socket delete patch, I think it's fine, it work around kernel limitations, and I think live patching the kernel to make it delete socket properly is quite ridiculous, even if a patch is upstream to BSD and Linux, Wine still support MacOS and LTS distro would not get the socket delete patches for year as they often run old kernels.
Socket delete commit: https://gitlab.winehq.org/wine/wine/-/merge_requests/2786/diffs?commit_id=22...
@zfigura If you have an idea, even tho I think the current code is fine, just send me how you want to be paid, I'm not insanely rich, but if you think you can rework the delete socket file in a way more fitting to be put into Wine, just go for it.