Rémi Bernon (@rbernon) commented about dlls/windows.devices.bluetooth/tests/bluetooth.c:
- {
todo_wine win_skip( "%s runtimeclass not registered, skipping tests.\n", wine_dbgstr_w( class_name ) );return;- }
- check_interface( inspectable, &IID_IUnknown );
- check_interface( inspectable, &IID_IInspectable );
- check_interface( inspectable, &IID_IAgileObject );
- hr = IInspectable_QueryInterface( inspectable, &IID_IBluetoothLEAdvertisementFilter, (void **)&filter );
- IInspectable_Release( inspectable );
- ok( hr == S_OK, "got hr %#lx.\n", hr );
- hr = IBluetoothLEAdvertisementFilter_get_Advertisement( filter, &adv );
- todo_wine ok( hr == S_OK, "got hr %#lx.\n", hr );
- ok( !!adv, "got adv %p\n", adv );
```suggestion:-2+0 adv = NULL; hr = IBluetoothLEAdvertisementFilter_get_Advertisement( filter, &adv ); todo_wine ok( hr == S_OK, "got hr %#lx.\n", hr ); todo_wine ok( !!adv, "got adv %p\n", adv ); ```
Although these todos are quite unnecessary at this point, this code isn't even reached on Wine. We usually prefer to add tests and implementations in a lock step to avoid having too many useless todo_wine around, which only makes adding stubs / implementation later more complicated (as you may need to adjust todo_wines a bit everywhere).
I think this MR could be shortened by adding just the Watcher tests and stubs first, then later add the other objects tests and stubs / impl.