Re: [PATCH v4 0/6] MR717: vkd3d-shader/fx: Add initial support for writing fx_2_0 parameters.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/fx.c:
>  set_u32(buffer, count_offset, count);
>
> }
>
> +static uint32_t get_fx_2_type_size(const struct hlsl_type *type)
> +{
> - uint32_t size = 0, elements_count;
> - size_t i;
> -
> - if (type->class == HLSL_CLASS_ARRAY)
> - {
> -
>    elements_count = hlsl_get_multiarray_size(type);
> -
>    type = hlsl_get_multiarray_element_type(type);
> -
>    return get_fx_2_type_size(type) * elements_count;
> - }
> - else if (type->class == HLSL_CLASS_STRUCT)

I guess structs can only contain numeric types, right? Otherwise the following function doesn't look right.