Re: [PATCH 0/2] MR1265: netprofm: Implement INetwork::GetNetworkConnections

[Hans Leidekker (＠hans)]

Hans Leidekker (@hans) commented about dlls/netprofm/list.c:
> static HRESULT WINAPI network_GetNetworkConnections(
>      INetwork *iface,
>      IEnumNetworkConnections **ppEnumNetworkConnection )
>  {
> - FIXME( "%p, %p\n", iface, ppEnumNetworkConnection );
> - return E_NOTIMPL;
> - HRESULT hr;
> - INetworkListManager *network_list_mgr = NULL;
> - struct list_manager *mgr = NULL;
> - struct network *current_network = impl_from_INetwork( iface );
> -
> - struct connection *connection, *next;
> - struct network *network;
> -
> - if (FAILED(hr = list_manager_create((void**)&network_list_mgr)))
> -
>    return hr;

We shouldn't need to create a new list manager here. You can instead store a pointer to the list manager in the network object if you take care to properly addref and release the objects.