On Tue Feb 18 20:39:57 2025 +0000, Vibhav Pant wrote:
It's bikeshedding, and I won't push very hard on this issue, but I
can't say I see any reason to keep the unix side only using one set of constants. If anything it seems more obscure to me; it's clearer to do as little conversion as possible. Hm, I don't see this function being used for other flags in the future, so using `LOCAL_RADIO_*` is definitely simpler. I've changed the code to using them.
I'd recommend it. I don't know that the bitfields _won't_ work, they
very well may, but they're not really necessary either. Sure, I'll try testing to see if the bitfields work for the next MR.
Hmm, well, if we can't rely on bitfields, we may have bigger problems anyway; several ntdll structs use them, e.g. MEM_EXTENDED_PARAMETER, XSTATE_CONFIGURATION, LDT_ENTRY.