Re: [PATCH v3 0/3] MR487: vkd3d-shader/hlsl: Fix infinite loops when applying copy-prop to swizzles, version 3.

[Francisco Casas (＠fcasas)]

On Wed Nov 22 21:22:09 2023 +0000, Zebediah Figura wrote:
> > I can totally change it if you insist, I just don't see the
>
> disadvantage of it being there.
> Clarity, mostly. It looks like an optimization at first glance, but if
> it were an optimization I'd expect to see
>             if (trace->record_count &&
> trace->records[trace->record_count - 1].timestamp <= time 
>                     && !trace->records[trace->record_count - 1].statically_written)
>                 continue;

I see, that is a better optimization. The disadvantage is that it is at the expense of making the asserts in the following calls to copy_propagation_set_value() and copy_propagation_invalidate_variable() less strong, because the time of the last record may remain smaller that the requested time of the invalidation.