Re: [PATCH 0/1] MR4530: d3drm: Set image->palette only once in d3drm_image_palettise (GCC).

[Alex Henrie (＠alexhenrie)]

On Tue Nov 28 19:27:08 2023 +0000, Zebediah Figura wrote:
> I prefer this version, frankly (and I find it clearer than the current
> code anyway), though I'm also struggling to see why GCC complains about
> the one but not the other?

To be clear, do you mean that you prefer Matteo's version, or the one I originally proposed?

GCC apparently thinks that colour_count might be 0, which means that realloc might free palette and return NULL. It's not smart enough to warn about the hypothetically dangling pointer that was saved to image->palette in Matteo's version because the pointer is not dereferenced in the immediate context, and even if it were dereferenced immediately, GCC still only warns when compiling with -fanalyzer.